[Bug 769029] Review Request: oxygen-gtk3 - Oxygen GTK+3 theme

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 21 08:13:45 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769029

T.C. Hollingsworth <tchollingsworth at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tchollingsworth at gmail.com

--- Comment #2 from T.C. Hollingsworth <tchollingsworth at gmail.com> 2011-12-21 03:13:45 EST ---
Just an informal review...

(In reply to comment #0)
> rpmlint output:
> rpmlint oxygen-gtk3.spec oxygen-gtk3-1.2.0-0.1.20111219.fc16.src.rpm
> oxygen-gtk3.spec:13: W: macro-in-comment %{version}
> oxygen-gtk3.spec:13: W: macro-in-comment %{version}
> oxygen-gtk3.spec:13: W: macro-in-comment %{snap}
> oxygen-gtk3.src:13: W: macro-in-comment %{version}
> oxygen-gtk3.src:13: W: macro-in-comment %{version}
> oxygen-gtk3.src:13: W: macro-in-comment %{snap}

Please escape RPM macros in comments like "%%{version}".

Other than that, the packaging looks good, it builds fine, and works great! 
Thanks a lot; I've been hoping to see this for awhile.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list