[Bug 769832] Review Request: kmod - Linux kernel module management utilities (official replacement for module-init-tools)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769832

--- Comment #4 from Neil Horman <nhorman at redhat.com> 2011-12-22 08:44:07 EST ---
[nhorman at hmsreliant x86_64]$ rpmlint ./kmod-2-2.fc15.x86_64.rpm 
kmod.x86_64: W: spelling-error %description -l en_US filesystems -> file
systems, file-systems, systematizes
kmod.x86_64: W: incoherent-version-in-changelog 2-1 ['2-2.fc15', '2-2']
kmod.x86_64: W: obsolete-not-provided modutils-devel
kmod.x86_64: W: obsolete-not-provided modutils
kmod.x86_64: E: binary-or-shlib-defines-rpath /sbin/kmod-rmmod ['/usr/lib64']
kmod.x86_64: E: binary-or-shlib-defines-rpath /sbin/kmod-modprobe
['/usr/lib64']
kmod.x86_64: E: binary-or-shlib-defines-rpath /sbin/kmod-insmod ['/usr/lib64']
kmod.x86_64: E: binary-or-shlib-defines-rpath /sbin/kmod-modinfo ['/usr/lib64']
kmod.x86_64: E: binary-or-shlib-defines-rpath /sbin/kmod-lsmod ['/usr/lib64']
kmod.x86_64: W: no-documentation
kmod.x86_64: W: no-manual-page-for-binary kmod-lsmod
kmod.x86_64: W: no-manual-page-for-binary kmod-rmmod
kmod.x86_64: W: no-manual-page-for-binary kmod-modinfo
kmod.x86_64: W: no-manual-page-for-binary kmod-insmod
kmod.x86_64: W: no-manual-page-for-binary kmod-modprobe
kmod.x86_64: W: dangerous-command-in-%pre mv
1 packages and 0 specfiles checked; 5 errors, 11 warnings.

Nothing really here that the source file didn't catch.  T

The changelog is an easy fix

The obsoletes have already been discussed

he binary-or-shlib errors are the result of the hardcoded /lib in the spec file
and will go away when thats fixed.

The docs should be included (at least NEWS README TODO and COPYING).  The last
one will help re-enforce the license selected in the spec file.

The man page stuff can be ignored, I'm sure it will get added as the package
continues to mature.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.