[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 22 18:16:51 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=767042

--- Comment #7 from Scott Tsai <scottt.tw at gmail.com> 2011-12-22 13:16:50 EST ---
(In reply to comment #6)
Updated spec at same URL:
1. Preserve timestamps with "cp -p"
2. Update license fields

diff --git a/js-of-ocaml.spec b/js-of-ocaml.spec
index 16c048d..7ca3b82 100644
--- a/js-of-ocaml.spec
+++ b/js-of-ocaml.spec
@@ -7,7 +7,7 @@ Version:        1.0.9
 Release:        1%{?dist}
 Summary:        An OCaml to Javascript compiler

-License:        LGPLv2+
+License:        LGPLv2+ with exceptions
 URL:            http://ocsigen.org/js_of_ocaml
 Source0:        http://ocsigen.org/download/js_of_ocaml-%{version}.tar.gz

@@ -38,6 +38,7 @@ Its key features are the following:
 Summary:        User manual and other documentation for %{name}
 Group:          Development/Libraries
 BuildArch:      noarch
+License:        (LGPLv2+ with exceptions) and GPLv2+ and WTFPL

 %description    doc
 The %{name}-doc package contains the user manual, API
@@ -56,14 +57,14 @@ export OCAMLFIND_DESTDIR=$RPM_BUILD_ROOT%{_libdir}/ocaml
 mkdir -p $OCAMLFIND_DESTDIR $OCAMLFIND_DESTDIR/stublibs
 D=$RPM_BUILD_ROOT%{_libdir}/ocaml/js_of_ocaml
 mkdir -p $D
-cp lib/META \
+cp -p lib/META \
     lib/*.{cmi,cma,a,mli} \
     lib/syntax/pa_js.cmo \
     runtime/runtime.js \
     $D
 mkdir -p $RPM_BUILD_ROOT%{_bindir}
-cp compiler/js_of_ocaml $RPM_BUILD_ROOT%{_bindir}/
-cp lib/dlljs_of_ocaml.so $OCAMLFIND_DESTDIR/stublibs/
+cp -p compiler/js_of_ocaml $RPM_BUILD_ROOT%{_bindir}/
+cp -p lib/dlljs_of_ocaml.so $OCAMLFIND_DESTDIR/stublibs/

 strip $OCAMLFIND_DESTDIR/stublibs/dll*.so
 chrpath --delete $OCAMLFIND_DESTDIR/stublibs/dll*.so
@@ -76,7 +77,7 @@ echo '-b /usr/bin/js_of_ocaml' >
$RPM_BUILD_ROOT/etc/prelink.conf.d/js-of-ocaml.
 # docs
 find examples '(' -name '*.cmi' -or -name '*.cmo' -or -name '*.byte' -or -name
'.depend' ')' -exec rm '{}' ';'
 # Replacing Makefile.common allows the user to build the examples
-cp %{SOURCE1} examples/Makefile.common
+cp -p %{SOURCE1} examples/Makefile.common

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list