[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770986

Mamoru Tasaka <mtasaka at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at fedoraproject.org
               Flag|                            |fedora-review?

--- Comment #1 from Mamoru Tasaka <mtasaka at fedoraproject.org> 2011-12-31 03:18:42 EST ---
Some notes:

* Build failure
  - Build fails on F-17:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=3611721

    -doc subpackage is marked as %doc, however generated
    rpms differ between i686 and x86_64.
    It can be said that this is a bug in ruby(-rdoc) side,
    however for now please consider rdoc-generated files
    arch-dependent.

* Arch dependent binary module
  - kgio_ext.so is arch-dependent and must be placed under
    %ruby_sitearch . Please check ruby packaging guideline.

* Redundant items
  - The following items are now redundant on Fedora (may not
    be under EPEL)
    - BuildRoot: line
    - %clean section (completely)
    - %defattr at the beginning of %files

* rpmlint issue
  - Please suppress (fix) the following rpmlint issues
------------------------------------------------------------
rubygem-kgio-doc.noarch: E: non-readable
/usr/lib/ruby/gems/1.8/gems/kgio-2.7.0/NEWS 0600L
rubygem-kgio-doc.noarch: E: non-readable
/usr/lib/ruby/gems/1.8/gems/kgio-2.7.0/ChangeLog 0600L
------------------------------------------------------------

* Documentation files placement
  - README file should be in main package, not -doc, because
    it says "README".
  - NEWS, ChangeLog can be in main package (and I recommend
    so), however not a blocker.

* Enabling test suite
  - As this gem contains test/ directory, please add %check
    section and execute some tests there
    Note: you may see some errors for missing "strace" module
    on ./test/test_autopush.rb:3, however I think this can be
    patched out.

By the way, I appreciate it if you would review my review request
(bug 770796)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.