[Bug 668822] Review Request: rubygem-memcache-client - A Ruby library for accessing memcached

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 1 23:56:20 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668822

--- Comment #3 from Mohammed Morsi <mmorsi at redhat.com> 2011-02-01 18:56:19 EST ---
Thanks alot for the review. Updated the rpm based on feedback:


Spec URL: http://mo.morsi.org/files/rpms/rubygem-memcache-client.spec
SRPM URL:
http://mo.morsi.org/files/rpms/rubygem-memcache-client-1.8.5-2.fc14.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2755539

If your taking this official review, please change the status of the bug to
'assigned', assign it to yourself, and change the 'fedora-review' flag to '?'



(In reply to comment #1)
> Some notes:
> 
> * License
>   - Must be pick up one or set another by LICENSE file.

Done

> 
> * BuildRoot
>   - On Fedora BuildRoot line is no longer needed:
>     https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
> 

Done

> * %check
>   - Feel free run test suite in a %check section in the rpm
> 

Done

> * %clean
>   - %clean section is no longer needed (on Fedora):
> https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
> 

Done

> * Unused macros
>   - Should use only the defined %geminstdir macro in %files.
>

Done 

> * documents / -doc subpackage
>   - Please consider to split document files (which are not
>     needed on runtime) to -doc subpackage.
>     The following files/directories can be moved to -doc subpackage
> ------------------------------------------------------
> %{gemdir}/doc/%{gemname}-%{version}/
> %{geminstdir}/test/
> # next line publish in Bugzilla?
> %{geminstdir}/Rakefile  - I don't know where it must be. May be it need
> only for tests.
> ------------------------------------------------------
> 

Leaving as is since the original gem shipped w/ these files. Marked as %doc
though

> * rpmbuild log:
> ------------------------------------------------------
> ...
> + /usr/lib/rpm/redhat/brp-java-repack-jars
> warning: File listed
> twice: /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/LICENSE.txt
> warning: File listed
> twice: /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/README.rdoc
> + umask 022
> + cd /home/pkg/rpmbuild/BUILD
> + rm
> -rf /home/pkg/rpmbuild/BUILDROOT/rubygem-memcache-client-1.8.5-1.fc14.x86_64
> + exit 0
> ------------------------------------------------------
> 
>  - There is twice definition - may be in %files
> 

Done

> * rpmlint log:
> ------------------------------------------------------
> rubygem-memcache-client.noarch: W: spelling-error Summary(en_US)
> memcached -> mem cached, mem-cached, mustached
> rubygem-memcache-client.noarch: W: spelling-error %description -l en_US
> memcached -> mem cached, mem-cached, mustached
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/%5b%5d-i.yaml %5b
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/%5b%5d-i.yaml %5d
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/raise_on_error_response%21-i.yaml
> %21
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/EM/SocketConnection/can_read%3f-i.yaml
> %3f
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/%5b%5d%3d-i.yaml
> %5b
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/%5b%5d%3d-i.yaml
> %5d
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/%5b%5d%3d-i.yaml
> %3d
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/EM/SocketConnection/closed%3f-i.yaml
> %3f
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/active%3f-i.yaml
> %3f
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/Server/alive%3f-i.yaml
> %3f
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/check_multithread_status%21-i.yaml
> %21
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/servers%3d-i.yaml
> %3d
> rubygem-memcache-client.noarch: W:
> unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/memcache-client-1.8.5/ri/MemCache/readonly%3f-i.yaml

All these can be ignored

> %3f
> rubygem-memcache-client.noarch: W:
> hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc
> rubygem-memcache-client.noarch: W:
> hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc
> rubygem-memcache-client.noarch: W: no-manual-page-for-binary

This one can be ignored too.

> memcached_top
> rubygem-memcache-client.src: W: spelling-error Summary(en_US) memcached
> -> mem cached, mem-cached, mustached
> rubygem-memcache-client.src: W: spelling-error %description -l en_US
> memcached -> mem cached, mem-cached, mustached
> 2 packages and 1 specfiles checked; 0 errors, 20 warnings.
> ------------------------------------------------------
> 
> * koji scratch build: green
>   - http://koji.fedoraproject.org/koji/taskinfo?taskID=2747123

(In reply to comment #2)
> * %install
> - Gems have permission 664, need 'chmod 644'

Which files are you refering to here?

Thanks alot for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list