[Bug 668822] Review Request: rubygem-memcache-client - A Ruby library for accessing memcached

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668822

--- Comment #5 from Mohammed Morsi <mmorsi at redhat.com> 2011-02-02 15:57:37 EST ---
Spec URL: http://mo.morsi.org/files/rpms/rubygem-memcache-client.spec
SRPM URL:
http://mo.morsi.org/files/rpms/rubygem-memcache-client-1.8.5-3.fc14.src.rpm

Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2758329

(In reply to comment #4)
> Looks good. May be approved with some notes.
> 
> (In reply to comment #3)
> 
> > > * %clean
> > >   - %clean section is no longer needed (on Fedora):
> > > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
> > > 
> > 
> > Done
> > 
> 
> - Don't change in spec-file.
> 

Done. (really this time ;-) ).

> 
> > (In reply to comment #2)
> > > * %install
> > > - Gems have permission 664, need 'chmod 644'
> > 
> > Which files are you refering to here?
> > 
> 
> I extract 'memcache-client-1.8.5.gem' from src.rpm at my box, it have
> permission 664.

Done. Thanks for this.

-------------------------------------------------------------------------------
> At my box 'rpmbuild' FAILED.
> error log:
> >>>
> ...
> error: Installed (but unpackaged) file(s) found:
>    /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/checksums
>    /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Cache.dat
>   
> /usr/lib/ruby/gems/1.8/gems/memcache-client-1.8.5/.yardoc/objects/Cache/add_c.dat 
<snip>
> koji scratch build green, here no these error messages
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2757774
> -------------------------------------------------------------------------------

Since Koji passed this doesn't matter so much. My guess is you have an
extraneous gem that you 'gem installed' instead of 'yum installed'. So long as
it builds on koji or in mock we should be good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.