[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
bugzilla at redhat.com
bugzilla at redhat.com
Thu Feb 3 07:27:43 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674673
--- Comment #2 from Tim Lauridsen <tla at rasmil.dk> 2011-02-03 02:27:41 EST ---
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)).
[x] : MUST - Package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
[x] : MUST - Each %files section contains %defattr
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[x] : MUST - Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the
beginning of %install.
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[!] : MUST - Rpmlint output is silent.
rpmlint lovelock-backgrounds-14.90.0-1.fc15.src.rpm
================================================================================
lovelock-backgrounds.src:32: W: macro-in-comment %package
lovelock-backgrounds.src:36: W: macro-in-comment %{name}
lovelock-backgrounds.src:36: W: macro-in-comment %{version}
lovelock-backgrounds.src:36: W: macro-in-comment %{release}
lovelock-backgrounds.src:38: W: macro-in-comment %description
lovelock-backgrounds.src:42: W: macro-in-comment %package
lovelock-backgrounds.src:46: W: macro-in-comment %{name}
lovelock-backgrounds.src:46: W: macro-in-comment %{version}
lovelock-backgrounds.src:46: W: macro-in-comment %{release}
lovelock-backgrounds.src:48: W: macro-in-comment %description
lovelock-backgrounds.src:77: W: macro-in-comment %package
lovelock-backgrounds.src:82: W: macro-in-comment %description
lovelock-backgrounds.src:85: W: macro-in-comment %package
lovelock-backgrounds.src:89: W: macro-in-comment %{name}
lovelock-backgrounds.src:91: W: macro-in-comment %description
lovelock-backgrounds.src:94: W: macro-in-comment %package
lovelock-backgrounds.src:98: W: macro-in-comment %{name}
lovelock-backgrounds.src:100: W: macro-in-comment %description
lovelock-backgrounds.src:133: W: macro-in-comment %files
lovelock-backgrounds.src:134: W: macro-in-comment %defattr
lovelock-backgrounds.src:135: W: macro-in-comment %dir
lovelock-backgrounds.src:135: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:136: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:137: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:138: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:140: W: macro-in-comment %files
lovelock-backgrounds.src:141: W: macro-in-comment %defattr
lovelock-backgrounds.src:142: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:143: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:154: W: macro-in-comment %files
lovelock-backgrounds.src:155: W: macro-in-comment %doc
lovelock-backgrounds.src:156: W: macro-in-comment %defattr
lovelock-backgrounds.src:157: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:159: W: macro-in-comment %files
lovelock-backgrounds.src:160: W: macro-in-comment %defattr
lovelock-backgrounds.src:161: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:162: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:164: W: macro-in-comment %files
lovelock-backgrounds.src:165: W: macro-in-comment %defattr
lovelock-backgrounds.src:166: W: macro-in-comment %{_kde4_datadir}
1 packages and 0 specfiles checked; 0 errors, 40 warnings.
================================================================================
False positives because some sections is commented out
rpmlint lovelock-backgrounds-gnome-14.90.0-1.fc14.noarch.rpm
================================================================================
lovelock-backgrounds-gnome.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
================================================================================
rpmlint lovelock-backgrounds-14.90.0-1.fc14.noarch.rpm
================================================================================
lovelock-backgrounds.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
================================================================================
rpmlint lovelock-backgrounds-kde-14.90.0-1.fc14.noarch.rpm
================================================================================
lovelock-backgrounds-kde.noarch: W: no-documentation
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1920x1200.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1920x1080.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1152x720.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1280x768.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/800x480.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/2048x1536.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1024x600.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1680x1050.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/640x480.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1024x768.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1366x768.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1280x720.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1440x900.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/800x600.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1920x1440.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1280x1024.png
../../../../backgrounds/lovelock/default/normalish/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1440x1080.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1600x1280.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1200x900.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1280x960.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1152x864.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1600x1200.png
../../../../backgrounds/lovelock/default/standard/lovelock.png
lovelock-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/Lovelock/contents/images/1280x800.png
../../../../backgrounds/lovelock/default/wide/lovelock.png
1 packages and 0 specfiles checked; 0 errors, 24 warnings.
================================================================================
I little unsure about this one, but i think is ok.
rpmlint lovelock-backgrounds-single-14.90.0-1.fc14.noarch.rpm
================================================================================
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
================================================================================
[x] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
MD5SUM this package : 9bdb3fbbf9eb8576a576e6b8ab15376f
MD5SUM upstream package : 9bdb3fbbf9eb8576a576e6b8ab15376f
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x] : MUST - Spec file is legible and written in American English.
[x] : MUST - Spec uses macros instead of hard-coded directory names.
[x] : MUST - Package consistently uses macros.
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[x] : MUST - Requires correct, justified where necessary.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[-] : MUST - The spec file handles locales properly.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - License field in the package spec file matches the actual license.
[x] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x] : MUST - License file installed when any subpackage combination is
installed.
[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - Sources contain only permissible code or content.
[x] : MUST - Compiler flags are appropriate.
[x] : MUST - %build honors applicable compiler flags or justifies otherwise.
[-] : MUST - ldconfig called in %post and %postun if required.
[x] : MUST - Package must own all directories that it creates.
[x] : MUST - Package does not own files or directories owned by other packages.
[x] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package does not contain duplicates in %files.
[x] : MUST - Permissions on files are set properly.
[x] : MUST - No %config files under /usr.
[-] : MUST - %config files are marked noreplace or the reason is justified.
[-] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[-] : MUST - Package contains a valid .desktop file.
[x] : MUST - Package contains code, or permissable content.
[-] : MUST - Package contains a SysV-style init script if in need of one.
[x] : MUST - File names are valid UTF-8.
[-] : MUST - Large documentation files are in a -doc subpackage, if required.
[x] : MUST - Package uses nothing in %doc for runtime.
[x] : MUST - Package contains no bundled libraries.
[-] : MUST - Header files in -devel subpackage, if present.
[-] : MUST - Static libraries in -static subpackage, if present.
[-] : MUST - Package contains no static executables.
[-] : MUST - Package requires pkgconfig, if .pc files are present.
[-] : MUST - Development .so files in -devel subpackage, if present.
[x] : MUST - Fully versioned dependency in subpackages, if present.
[x] : MUST - Package does not contain any libtool archives (.la).
[-] : MUST - Useful -debuginfo package or justification otherwise.
[x] : MUST - Rpath absent or only used for internal libs.
[x] : MUST - Package does not genrate any conflict.
[x] : MUST - Package does not contains kernel modules.
[x] : MUST - Package is not relocatable.
[X] : MUST - Package is not known to require ExcludeArch.
[x] : MUST - Package installs properly.
[x] : MUST - Package obeys FHS, except libexecdir and /usr/target.
[x] : MUST - Package meets the Packaging Guidelines.
[x] : SHOULD - Dist tag is present.
[x] : SHOULD - SourceX is a working URL.
[x] : SHOULD - Package functions as described.
[x] : SHOULD - Latest version is packaged.
[x] : SHOULD - Package does not include license text files separate from
upstream.
[-] : SHOULD - If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[!] : SHOULD - Description and summary sections in the package spec file
contains translations for supported Non-English languages, if available.
[x] : SHOULD - SourceX / PatchY prefixed with %{name}.
[x] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm
-q --requires).
[-] : SHOULD - %check is present and all tests pass.
[x] : SHOULD - Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[?] : SHOULD - Reviewer should test that the package builds in mock.
[?] : SHOULD - Package should compile and build into binary rpms on all
supported architectures.
[-] : SHOULD - Spec use %global instead of %define.
[-] : SHOULD - Scriptlets must be sane, if used.
[-] : SHOULD - The placement of pkgconfig(.pc) files are correct.
[x] : SHOULD - No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[?] : SHOULD - Packages should try to preserve timestamps of original installed
files.
[-] : SHOULD - File based requires are sane.
[-] : SHOULD - Man pages included for all executables.
[?] : SHOULD - Uses parallel make.
[-] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise
justified.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list