[Bug 674676] Review Request: python-zope-deprecation - Zope 3 Deprecation Infrastructure

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 3 14:12:02 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


Luke Macken <lmacken at redhat.com> changed:

           What    |Removed                     |Added
               Flag|                            |needinfo?(robinlee.sysu at gma
                   |                            |il.com)

--- Comment #2 from Luke Macken <lmacken at redhat.com> 2011-02-03 09:12:01 EST ---
(In reply to comment #1)
> Others:
> [=] Consider renaming python-setuptools-devel to python-setuptools


> [-] Source0 URL:
> http://pypi.python.org/packages/source/z/%{modname}/%{modname}-%{version}.tar.gz


> [=] Buildroot, %clean section and the rm command in %install section are not
> required.
> http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
> http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

I'd like to keep these for now, until I push this all of the way down to EL-5. 
I also added the python_sitelib definition to the top.

> [=] /usr/lib/python2.7/site-packages/zope/deprecation/DEPENDENCIES.cfg
> /usr/lib/python2.7/site-packages/zope/deprecation/README.txt
> should be excluded.


> [=] The tests not actually run.
> 'zope.testrunner' is required but not available in Fedora. 'zope.testrunner'
> used to be part of 'zope.testing'.
> I ran the tests locally and all went well:
> $ ./bin/test 
> Running zope.testrunner.layer.UnitTests tests:
>   Set up zope.testrunner.layer.UnitTests in 0.000 seconds.
>   Ran 19 tests with 0 failures and 0 errors in 0.110 seconds.
> Tearing down left over layers:
>   Tear down zope.testrunner.layer.UnitTests in 0.000 seconds.

Ok, removed %check block for now.

> [=] Consider excluding the tests
> /usr/lib/python2.7/site-packages/zope/deprecation/tests.py*

Removed during %install.

Updated SPEC/SRPM at original URL.

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list