[Bug 675050] Review Request: cloudfs - Cloud Filesystem

bugzilla at redhat.com bugzilla at redhat.com
Fri Feb 4 14:34:07 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675050

--- Comment #4 from Ralf Corsepius <rc040203 at freenet.de> 2011-02-04 09:34:06 EST ---
(In reply to comment #3)
> Are you sure about that "obvious bug" Ralf?
Hmm,

/usr/include/glusterfs/iatt.h
contains
#include "uuid.h"

This means this file want to include /usr/include/uuid.h

>  The intended reference is actually
> to /usr/include/glusterfs/uuid.h which is owned by glusterfs-devel, not
> /usr/include/uuid.h which is owned by uuid-devel. 
Then the glusterfs headers' design is questionable, because they depend
upon -I/usr/include/glusterfs and fail otherwise (cf. above).

This also is a questionable and error-prone design, because 
passing -I/usr/include/glusterfs then will shadow /usr/include/uuid.h, 
i.e. render including both headers from inside of the same build directory will
become difficult.

I'd recommend glusterfs to change their headers to using <glusterfs/...h>.

> This file was not installed
> prior to glusterfs-devel-3.1.2-2, which is why I mentioned it above, but with
> that version it does build.
In this case, your build requires are not strict enough.

BR: glusterfs >= <minimum version>

>  Is it possible that 3.1.2-2 just hasn't hit the
> repo yet?

Probably - I was building your package in mock with what was current then 
(And yes, Fedora's repos being out of sync and/or being broken is an often
occuring and long-term persisting issue to me).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list