[Bug 571019] Review Request: libmtag - An advanced C music tagging library with a simple API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=571019

--- Comment #10 from Felipe Contreras <felipe.contreras at gmail.com> 2011-02-05 09:52:44 EST ---
(In reply to comment #9)
> Hmm, it seems the .src.rpm is 404 too. Please fix that, I need to src.rpm to
> complete the review. In the mean time I've done most of the review based on the
> .spec file:

What's the point of providing the .spec file if it's generated from the .spec
and tarball? (both have been provided)

Anyway, libmtag:
http://people.freedesktop.org/~felipec/fedora/libmtag.spec
http://people.freedesktop.org/~felipec/fedora/libmtag-0.3.6-1.fc14.src.rpm

libmtag-python:
http://people.freedesktop.org/~felipec/fedora/libmtag-python.spec
http://people.freedesktop.org/~felipec/fedora/libmtag-python-0.3.1-1.fc14.src.rpm

Here's a koji build for the first, I don't know how to do it for the second:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2763785

> Needs work:
> - source matches upstream
>   I could not verify this because of the lack of a .src.rpm

rpmbuild -ba libmtag.spec

> - summary
>   Please drop the An from the summary, as a general rule we try to not have
>   Summaries start with A, An or The.

Done.

> - %doc (main package)
>   Please add README and NEWS to the main package %doc, they seem useful
>   to have around to me.

Done.

(In reply to comment #8)
> python bindings would make a fine second package submission to show some more
> of your packaging skills.
> 
> I'll go and review this package now, but, once reviewed, I would still like to
> see something more of your packaging skills before sponsoring you.

Done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.