[Bug 675402] Review Request: qpass - password manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675402

Golo Fuchert <packages at golotop.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |packages at golotop.de
             Blocks|                            |177841(FE-NEEDSPONSOR)

--- Comment #1 from Golo Fuchert <packages at golotop.de> 2011-02-05 18:02:35 EST ---
I have a few initial comments on your package:

- there is a typo in the summary (buil-in)
- have you checked if you really need the version numbers in the 
  (Build)Requires?
  You need them only, if there are older versions available for currently 
  supported versions of Fedora and maybe RHEL (if you want to package for it).
  Additionally you should check if the Requires are really needed, just from 
  looking at the spec file I would assume not (see
http://fedoraproject.org/wiki/PackagingGuidelines#Requires ).
- Lines should not be longer than 80 characters in the description.
- You made a very common mistake in the files section: %{_datadir}/%{name}/*
  This way the package will only own the files _in_ the directory 
  %{_datadir}/%{name}/, if the user now uninstalls the package, the directory 
  will remain on the user's system. So you need to own this by writing 
  %{_datadir}/%{name}/ in the files section. By that, the directory itself
_and_
  the files in the directory are owned by the package.
http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Unowned_Directories
- Write something in the changelog, even for the very first version of the 
  package. For example
  * Sun Feb 6 2011 Your Name <your_adress at email.com> 0.1-1
  - initial packaging

  If you don't understand the first line, have a closer look at that topic
  in the Guidelines.
- You need to verify the desktop file:
  http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage
- You need to update the icon cache:
  http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

Don't be upset now, the package looks already quite clear for your first try!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.