[Bug 675402] Review Request: qpass - password manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675402

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #3 from Martin Gieseking <martin.gieseking at uos.de> 2011-02-06 15:29:17 EST ---
Here are a couple of further notes:

- Please drop "Requires: qt, libgcrypt". Both dependencies are detected 
  automatically.

- Don't mix spaces and tabs for indentation. Choose one of them and stick with 
  it.

- Replace Group "Application/Internet" with "Applications/Internet"

- Add the missing buildroot dir to the location of the desktop file:
  desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/qpass.desktop

- You should install file COPYING into %{_defaultdocdir}/%{name}-%{version}/.
  One way to do that is to remove the installed file from the buildroot and add
  it with %doc in section %files:
  in %install: rm -f $RPM_BUILD_ROOT%{_datadir}/%{name}/COPYING
  in %files: replace %{_datadir}/%{name}/COPYING with %doc COPYING

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.