[Bug 668243] Review Request: libqb - An IPC library for high performance servers.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668243

Ian Weller <ian at ianweller.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian at ianweller.org
         AssignedTo|fdinitto at redhat.com         |ian at ianweller.org

--- Comment #15 from Ian Weller <ian at ianweller.org> 2011-02-07 19:03:16 EST ---
Hi Angus,

I've been asked by Robyn Bergeron to sponsor you for this package, and I am
willing to do so. Just had a few questions:

- Do you have any other pending package reviews, or have you done any informal
  reviews of other packages?
- In your spec, you document three variables at the top; are they just not set
in
  this release of the spec? (I would recommend having the definitions for each
of
  the variables in that comment block, but just commented out when they are not
  in use.)
- Also on those variables, please make sure that they follow the release tag
  guidelines:
    https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
  At first glance, it appears that you may end up breaking some of those
  guidelines if you're not careful.
- Did you make sure that there were no dependencies on other headers in the
devel
  subpackage? The devel subpackage only requires pkgconfig.
- Instead of using %dir %{_includedir}/qb/ and listing each file in it
  individually, clean up your %files list by just listing %{_includedir}/qb/ --
  without the %dir command, it will include that directory and everything in
it.
  Consider this a blocker.

(Because I'm willing to sponsor you, I'm assigning this request to me.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.