[Bug 668243] Review Request: libqb - An IPC library for high performance servers.

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 8 01:09:31 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668243

--- Comment #16 from Angus Salkeld <asalkeld at redhat.com> 2011-02-07 20:09:30 EST ---
(In reply to comment #15)
> Hi Angus,
> 
> I've been asked by Robyn Bergeron to sponsor you for this package, and I am
> willing to do so. Just had a few questions:

Cool, thanks!

> 
> - Do you have any other pending package reviews, or have you done any informal
>   reviews of other packages?

Nope, just this one.

> - In your spec, you document three variables at the top; are they just not set
> in
>   this release of the spec? (I would recommend having the definitions for each
> of
>   the variables in that comment block, but just commented out when they are not
>   in use.)

They are mainly used upstream, I am just trying to keep this and the upstream
in-sync as much as possible.
I tried adding them to the comment but had an rpmlint warning about having a
variable in a comment.

> - Also on those variables, please make sure that they follow the release tag
>   guidelines:
>     https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
>   At first glance, it appears that you may end up breaking some of those
>   guidelines if you're not careful.

My idea was not to use these in the fedora release number.
(if doing an alpha release, I'll manually edit the "Release" string).

> - Did you make sure that there were no dependencies on other headers in the
> devel
>   subpackage? The devel subpackage only requires pkgconfig.

I believe so, we don't need std headers & man do we?
Is here a way of checking? I have done rpmlint and koji builds without
problems.

> - Instead of using %dir %{_includedir}/qb/ and listing each file in it
>   individually, clean up your %files list by just listing %{_includedir}/qb/ --
>   without the %dir command, it will include that directory and everything in
> it.

OK, thanks - didn't know about that.

>   Consider this a blocker.
> 
> (Because I'm willing to sponsor you, I'm assigning this request to me.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list