[Bug 668243] Review Request: libqb - An IPC library for high performance servers.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668243

--- Comment #18 from Fabio Massimo Di Nitto <fdinitto at redhat.com> 2011-02-08 00:55:15 EST ---
Hi Ian,

(In reply to comment #15)
> Hi Angus,
> 
> I've been asked by Robyn Bergeron to sponsor you for this package, and I am
> willing to do so. Just had a few questions:

thanks for taking over here.

> - Instead of using %dir %{_includedir}/qb/ and listing each file in it
>   individually, clean up your %files list by just listing %{_includedir}/qb/ --
>   without the %dir command, it will include that directory and everything in
> it.

I have a question about this change. I am really working hard to improve my
packaging skills, to eventually become a sponsor, but I am not entirely sure
why one way is better than other.

In my head, the one liner is clearly easier to read in a spec file, but listing
all files has other benefits, such as detecting possible leaks of unwanted
files in there (an upstream build error for example), or possible API changes
by moving functions around to new headers, and that would allow the packagers
to easily spot them and possible notify the API users (there was a similar,
very detailed message - Subject: Poppler soname bump - that I find very
polite).

Thanks for your time.
Fabio

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.