[Bug 675963] Review Request: perl-MDV-Packdrakeng - Simple Archive Extractor/Builder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675963

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2011-02-08 08:50:21 EST ---
Source tar ball is original. Ok.
Summary verified from lib/MDV/Packdrakeng.pm. Ok.
License verified from lib/MDV/Packdrakeng.pm. Ok.
No C binding, noarch BuildArch Ok.
Description verified from lib/MDV/Packdrakeng.pm. Ok.

TODO: BuildRequire perl(File::Path) (lib/MDV/Packdrakeng.pm:23) as the package
can dual-live in the future (http://search.cpan.org/~dland/File-Path/).

perl(Compress::Zlib) dependency (lib/MDV/Packdrakeng.pm:144) is optional. Ok.

FIX: BuildRequire perl(Test::More) to proceed all tests (t/01packdrakeng.t:6).
FIX: BuildRequire perl(Digest::MD5) to proceed all tests (t/01packdrakeng.t:7).

TODO: BuildRequire perl(Compress::Zlib) to perform all tests
(t/02methodusage.t:12).

All tests pass. Ok.

$ rpmlint perl-MDV-Packdrakeng.spec
../SRPMS/perl-MDV-Packdrakeng-1.13-1.fc14.src.rpm
../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm
drwxr-xr-x    2 root    root                        0 úno  8 14:38
/usr/share/doc/perl-MDV-Packdrakeng-1.13
-rw-r--r--    1 root    root                     4065 srp  9  2007
/usr/share/doc/perl-MDV-Packdrakeng-1.13/ChangeLog
-rw-r--r--    1 root    root                      228 kvě  6  2007
/usr/share/doc/perl-MDV-Packdrakeng-1.13/README
-rw-r--r--    1 root    root                     4664 úno  8 14:38
/usr/share/man/man3/MDV::Packdrakeng.3pm.gz
-rw-r--r--    1 root    root                     1831 úno  8 14:38
/usr/share/man/man3/MDV::Packdrakeng::zlib.3pm.gz
drwxr-xr-x    2 root    root                        0 úno  8 14:38
/usr/share/perl5/MDV
drwxr-xr-x    2 root    root                        0 úno  8 14:38
/usr/share/perl5/MDV/Packdrakeng
-rw-r--r--    1 root    root                    30528 srp  9  2007
/usr/share/perl5/MDV/Packdrakeng.pm
-rw-r--r--    1 root    root                     7517 srp  9  2007
/usr/share/perl5/MDV/Packdrakeng/zlib.pm
File permissions and layout Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm | sort | uniq -c
      1 perl(base)  
      1 perl(Compress::Zlib)  
      1 perl(File::Path)  
      1 perl(:MODULE_COMPAT_5.12.3)  
      1 perl(POSIX)  
      1 perl(strict)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      2 rpmlib(VersionedDependencies) <= 3.0.3-1
Binary requires Ok.

rpm -q --provides -p ../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm
| sort | uniq -c
      1 perl(MDV::Packdrakeng::zlib)  
      1 perl(MDV::Packdrakeng) = 1.13
      1 perl-MDV-Packdrakeng = 1.13-1.fc14
Binary provides Ok.

$ resolvedeps-f15 ../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm 
Binary dependencies resolvable. Ok.

FIX: Package does not build in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2784614). This is due to
missing BuildRequires for tests.

Othwerwise package is in line with Fedora and perl packaging guidelines.


Please correct all `FIX' prefixed issues, consider fixing `TODO' prefixed
issues, and provide new spec file.
Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.