[Bug 669146] Review Request: gnumed-server - medical practice management - server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669146

--- Comment #3 from Susmit <thinklinux.ssh at gmail.com> 2011-02-09 09:36:21 EST ---
Thanks for the comments.
Please find the inline comments.

> A few comments; too many things wrong to do a full review at this time.  I sure
> hope this isn't a copy of the package upstream is currently offering, because
> I'm afraid that making an acceptable package is going to make it difficult to
> keep much compatibility with that one.

No, my packaging skills are not world class yet. ;)

> The Source0: URL is invalid; upstream only seems to have 14.5 there.  Given
> that, I probably shouldn't build this, but what the heck, it's a disposable
> build machine.

They did release a 14.6, but for some reason it is not in the directory.
I shall be working with upstream to get it resolved.

> rpmlint says:
>   gnumed-server.noarch: W: only-non-binary-in-usr-lib
> This is very problematic.  The package references _libdir, so the location of
> the files depends on the architecture it was built on, but it's a noarch
> package.  Plus things reference /usr/lib explicitly while that stuff is in
> /usr/lib64 on my build.  Are you sure the stuff that's in _libdir shouldn't be
> in _datadir instead?  What there is arch-specific?

I am having a look. 

>   gnumed-server.noarch: W: no-documentation
>   gnumed-server.noarch: W: no-manual-page-for-binary gm-remove_person.sh
>   gnumed-server.noarch: W: no-manual-page-for-binary gm-move_backups_offsite.sh
>   gnumed-server.noarch: W: no-manual-page-for-binary gm-backup_database.sh
>   gnumed-server.noarch: W: no-manual-page-for-binary gm-restore_database.sh
>   gnumed-server.noarch: W: no-manual-page-for-binary gm-adjust_db_settings.sh
>   gnumed-server.noarch: W: no-manual-page-for-binary gm-bootstrap_server
>   gnumed-server.noarch: W: no-manual-page-for-binary gm-backup_data.sh
>   gnumed-server.noarch: W: no-manual-page-for-binary gm-restore_data.sh
>   gnumed-server.noarch: W: no-manual-page-for-binary gm-zip+sign_backups.sh
> It's nice to have _some_ documentation, and it looks like this package has
> some.  At least there's a license text and some manpages, buried under _libdir.
>  Is there some reason those shouldn't be installed into the proper places?

I am having a look.

> Why are the same scripts installed in two places?
> How do you configure this package?  Nothing is installed under /etc and nothing
> is marked as %conf.

My mistake. Sorry.



> If this is a server, how do you start and stop it?  Doesn't it need an
> initscript?

The way it works is this: One copies it over to relevant directories and then
run a bootstrap script which sets up the database and the necessary
configurations. 

> Why does this require a local postgres server?  Will it not work with a remote
> one?

The upstream wiki mentions that it _requires_ a local server.

Thanks for the initial review, I shall get these corrected.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.