[Bug 674180] Review Request: knights - A chess board for KDE

Wed Feb 9 22:22:38 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=674180

--- Comment #12 from Golo Fuchert <packages at golotop.de> 2011-02-09 17:22:36 EST ---
Julian,

the package is almost ready, only the permissions for one file needs to be
corrected.

$ rpmlint SPECS/knights.spec SRPMS/knights-2.2.0-3.fc14.src.rpm
RPMS/i686/knights-2.2.0-3.fc14.i686.rpm 
knights.src: W: spelling-error %description -l en_US multiplayer -> multilayer,
multiplexer, multiplier
knights.i686: W: spelling-error %description -l en_US multiplayer ->
multilayer, multiplexer, multiplier
knights.i686: E: script-without-shebang
/usr/share/applications/kde4/knights.desktop
knights.i686: W: no-manual-page-for-binary knights
2 packages and 1 specfiles checked; 1 errors, 3 warnings.

Spelling errors are false positives, the .desktop file seems to have wrong
permissions (755).

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    - GPLv2 or GPLv3 (with the possibility for an extension by KDE e.V.)
[+] MUST: The License field in the package spec file must match the actual
license.
[.] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum knights-2.2.0.tar.bz2{,.packaged}
    6196e8ef8d2e7c16e38307469708f7cf  knights-2.2.0.tar.bz2
    6196e8ef8d2e7c16e38307469708f7cf  knights-2.2.0.tar.bz2.packaged

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
    - implicitly by %cmake_kde4
[+] MUST: The spec file MUST handle locales properly.
[+] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[X] MUST: Permissions on files must be set properly.
    - see the rpmlint output above
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
    - has been/will be done by the packager.
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The reviewer should test that the package functions as described.
    - Almost, the description didn't warn the reviewer to lose against
      gnuchess. ;-)
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[X] SHOULD: Your package should contain man pages for binaries/scripts.
    - Maybe a plan for the future?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.