[Bug 671883] Review Request: v4l-utils - Utilities for video4linux and DVB devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=671883

--- Comment #10 from Peter Robinson <pbrobinson at gmail.com> 2011-02-10 09:58:38 EST ---
Mostly OK. I think the QT app needs a desktop file (but it might not be an app
that shoud) and there should be versioned required on the libs at a guess for
the various utils.

- non -devel packages should require fully versioned base
- packages containing GUI apps must include %{name}.desktop file


+ rpmlint output

rpmlint v4l* libv4l-0.8.3-1.fc15.x86_64.rpm
libv4l-devel-0.8.3-1.fc15.x86_64.rpm qv4l2-0.8.3-1.fc15.x86_64.rpm
v4l-utils.src: W: spelling-error %description -l en_US ctl -> cyl, ct, cl
v4l-utils.src: W: spelling-error %description -l en_US ir -> IR, Ir, or
v4l-utils.src: W: spelling-error %description -l en_US keytable -> key table,
key-table, marketable
v4l-utils.src: W: spelling-error %description -l en_US ivtv -> invt, Ives, Ivan
v4l-utils.src: W: spelling-error %description -l en_US sysfs -> sysops, sysop,
systems
v4l-utils.x86_64: W: spelling-error %description -l en_US ctl -> cyl, ct, cl
v4l-utils.x86_64: W: spelling-error %description -l en_US ir -> IR, Ir, or
v4l-utils.x86_64: W: spelling-error %description -l en_US keytable -> key
table, key-table, marketable
v4l-utils.x86_64: W: spelling-error %description -l en_US ivtv -> invt, Ives,
Ivan
v4l-utils.x86_64: W: spelling-error %description -l en_US sysfs -> sysops,
sysop, systems
v4l-utils.x86_64: W: no-manual-page-for-binary v4l2-sysfs-path
v4l-utils.x86_64: W: no-manual-page-for-binary ivtv-ctl
v4l-utils.x86_64: W: no-manual-page-for-binary v4l2-ctl
v4l-utils.x86_64: W: no-manual-page-for-binary cx18-ctl
v4l-utils-devel-tools.x86_64: W: spelling-error %description -l en_US dbg ->
db, dg, deg
v4l-utils-devel-tools.x86_64: W: no-manual-page-for-binary decode_tm6000
v4l-utils-devel-tools.x86_64: W: no-manual-page-for-binary v4l2-dbg
v4l-utils-devel-tools.x86_64: W: no-manual-page-for-binary v4l2-compliance
qv4l2.x86_64: W: no-manual-page-for-binary qv4l2
7 packages and 1 specfiles checked; 0 errors, 19 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ latest version packaged

+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  f25ad639717d7411a58f10a9e378d7db  v4l-utils-0.8.3.tar.bz2
+ package successfully builds on at least one architecture
  tested using koji scratch build
  http://koji.fedoraproject.org/koji/taskinfo?taskID=2829854
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
+ binary RPM with shared library files must call ldconfig in %post and %postun+
does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ Package perserves timestamps on install
+ Permissions on files must be set properly 
+ %defattr line
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime 
+ header files should be in -devel
n/a static libraries should be in -static
- non -devel packages should require fully versioned base
+ packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
+ libfoo.so must go in -devel
+ devel must require the fully versioned base
+ packages should not contain libtool .la files
- packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
+ the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
- Package should have man files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.