[Bug 673658] Review Request: R-Rcompression - In-memory decompression for GNU zip and bzip2 formats.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673658

--- Comment #1 from Haïkel Guémar <karlthered at gmail.com> 2011-02-12 13:43:33 EST ---
R-Rcompression

all relevant MUST and SHOULD points are listed here.

Must: rplint on src.rpm and binary rpms   OK (nothing relevant or in violation
to packaging guidelines
$ rpmlint -iv R-Rcompression-0.92.0-1.fc14.src.rpm
R-Rcompression.src: I: checking
R-Rcompression.src: W: spelling-error %description -l en_US zlib -> lib, glib,
z lib
The value of this tag appears to be misspelled. Please double-check.

R-Rcompression.src: W: spelling-error %description -l en_US uncompressing ->
uncompressed, compressing, uncomprehending
The value of this tag appears to be misspelled. Please double-check.

R-Rcompression.src: W: spelling-error %description -l en_US gzip -> zip, grip,
g zip
The value of this tag appears to be misspelled. Please double-check.

R-Rcompression.src: I: checking-url
http://www.omegahat.org/Rcompression/index.html (timeout 10 seconds)
R-Rcompression.src: I: checking-url
http://www.omegahat.org/Rcompression/Rcompression_0.92-0.tar.gz (timeout 10
seconds)
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


$ rpmlint -iv R-Rcompression-0.92.0-1.fc14.x86_64.rpm
R-Rcompression.x86_64: I: checking
R-Rcompression.x86_64: W: spelling-error %description -l en_US zlib -> lib,
glib, z lib
The value of this tag appears to be misspelled. Please double-check.

R-Rcompression.x86_64: W: spelling-error %description -l en_US uncompressing ->
uncompressed, compressing, uncomprehending
The value of this tag appears to be misspelled. Please double-check.

R-Rcompression.x86_64: W: spelling-error %description -l en_US gzip -> zip,
grip, g zip
The value of this tag appears to be misspelled. Please double-check.

R-Rcompression.x86_64: I: checking-url
http://www.omegahat.org/Rcompression/index.html (timeout 10 seconds)
R-Rcompression.x86_64: W: unable-to-read-zip
/usr/lib64/R/library/Rcompression/sampleData/tests.zip: File bzTar.R is
encrypted, password required for extraction
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

MUST: package is named accordingly to general and R specific naming guidelines
OK

MUST: spec file name matches %{name} OK

MUST: package meet packaging guidelines OK

MUST: package is licensed under a fedora compliant license (BSD) OK

Note: Description says BSD, but they have used zlib licensed code, both
licenses are fedora-compliant and almost the same (but not interchangeable)
but i feel that upstream should fix this issue in relicensing the whole under
zlib license. I have confidence that you'll sort that minor issue later.
NOTABLOCKER.
No license file included, so no need to provide it.

MUST: spec is written in legible american english. OK

MUST: provided and upstream sources checksums match.  OK
provided sources: 8166316349e8e032fcedb9b4813a01286bdee711
upstream sources: 8166316349e8e032fcedb9b4813a01286bdee711

MUST: compilation tested on all supported platforms (x86 and x86_64) for F14
under mock. KO
Note: missing BR & R to zip, except that, it compiles fine.

MUST: don't bundle third party libraries though it borrowed some zlib code. OK

MUST: package owns created directories (and only them). OK

MUST: files are not listed twice. OK

MUST: files permissions are properly set. OK

MUST: consistent use of macros. OK

MUST: only ships permissible content. OK

MUST: doc is properly handled. OK

MUST: filenames are valid UTF-8. OK 

General and R specific guidelines are more or less respected, as soon as you
fix the mock build issue, it will be approved (the minor license issue could be
fixed later).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.