[Bug 673661] Review Request: R-ALL - Data of T- and B-cell Acute Lymphocytic Leukemia

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673661

Haïkel Guémar <karlthered at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Haïkel Guémar <karlthered at gmail.com> 2011-02-12 15:23:06 EST ---
R-ALL (noarch package)

all relevant MUST and SHOULD points are listed here.

Must: rplint on src.rpm and binary rpms   OK 
$ rpmlint -iv R-XML-3.2.0-1.fc14.src.rpm
R-ALL.src: I: checking
R-ALL.src: I: checking-url
http://www.bioconductor.org/packages/release/data/experiment/html/ALL.html
(timeout 10 seconds)
R-ALL.src: I: checking-url
http://www.bioconductor.org/packages/release/data/experiment/src/contrib/ALL_1.4.7.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -iv R-ALL-1.4.7-1.fc14.noarch.rpm
R-ALL.noarch: I: checking
R-ALL.noarch: I: checking-url
http://www.bioconductor.org/packages/release/data/experiment/html/ALL.html
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

MUST: package is named accordingly to general and R specific naming guidelines.
OK
Note: seems that using real names in changelog is no more written in
guidelines, 
but it's a good practice, and i expect that you change this.

MUST: spec file name matches %{name} OK

MUST: package meet packaging guidelines. OK 

MUST: package is licensed under a fedora compliant license (GPL+) OK
Note: tarball says GPL but it has not much meaning, ask upstream to clarify
which versions of GPL is supported (they'd probably go with GPLv2+ to ensure a
maximum compatibility with existing free softwares). i have confidence that
you'll sort this issue with upstream as soon as possible. Since, upstream
clearly stated that the software is licensed under a fedora compliant license
(version issue aside) ==> NOTABLOCKER.

MUST: spec is written in legible american english. OK

MUST: provided and upstream sources checksums match.  OK
provided sources: ed919079b1177f1c8f02c84c4b78cfc6710a573d
upstream sources: ed919079b1177f1c8f02c84c4b78cfc6710a573d

MUST: compilation tested on all supported platforms (x86 and x86_64) for F14
under mock. OK

MUST: package doesn't bundle third party libraries. OK

MUST: package owns created directories (and only them). OK

MUST: files are not listed twice. OK

MUST: files permissions are properly set. OK

MUST: consistent use of macros. OK

MUST: only ships permissible content. OK

MUST: doc is properly handled. OK

MUST: filenames are valid UTF-8. OK 

General and R specific guidelines are respected, under the reserve that you use
your real name in changelog and ask upstream to fix licensing terms (it could
wait, next package update), i'll approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.