[Bug 676544] Review Request: Pidgin-logviewer - User friendly and intuitive way of viewing chat logs in Pidgin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676544

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de> 2011-02-14 09:54:50 EST ---
The source archive contains prebuilt binaries in src/. These must be removed to
ensure that all binaries are newly created during the build process.
Thus, add the following lines to %prep:
  cd src
  rm -rf .libs .deps *.o *.lo *.la

I also recommend to checkout the sources with "svn export" to avoid creating
.svn directories.

Since you grabbed the sources from the svn trunk, the package provides a
snapshot release. Please see here how to reflect this in the Release field:
http://fedoraproject.org/wiki/PackageNamingGuidelines#Snapshot_packages

If you want to maintain this package for EPEL < 6 too, you must add a %clean
section. Otherwise, don't remove %clean only but also drop the BuildRoot tag
and rm -rf $RPM_BUILD_ROOT (in %install).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.