[Bug 676188] Review Request: qmidiarp - an arpeggiator, sequencer and MIDI LFO for ALSA

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676188

Mario Blättermann <mario.blaettermann at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann at gmail.co
                   |                            |m

--- Comment #1 from Mario Blättermann <mario.blaettermann at gmail.com> 2011-02-14 15:15:44 EST ---
I think it's OK to leave "arpeggiator" untouched, because not all dictionaries
know about all existing words.

The package has properly built on my system. Some issues regarding the spec
file:

- Please use macros consistently. In "Source2" and in the "%files" section, you
should replace the original package name with %{name}, as you already did in
the other rows.

- If you are using spaces within key/value pairs such as "Name:" or "Version:"
please use a whitespace count which leads to a better readability. I would
recommend using tabs instead of normal whitespace characters here.

- Although your package doesn't install SVG icons, the %post and %postun macros
refer to the SVG folder. Don't know what to do in this case, I assume the
folder path has to be changed to the correct installation folder of the icon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.