[Bug 676146] Review request: trace-gui - GUI tools from trace-cmd

Mon Feb 14 21:50:12 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=676146

--- Comment #1 from Christoph Wickert <cwickert at fedoraproject.org> 2011-02-14 16:50:11 EST ---
REVIEW FOR b1759276bf8aec03a09306b1683894ab  trace-gui-1.0.4-1.fc13.src.rpm

FIX - MUST:  rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
trace-gui.src: W: spelling-error Summary(en_US) cmd -> cm, cd, cad
trace-gui.src: W: summary-not-capitalized C trace-cmd is a user interface to
Ftrace
trace-gui.src: W: spelling-error %description -l en_US cmd -> cm, cd, cad
trace-gui.src: W: spelling-error %description -l en_US debugfs -> debugs,
debuggers, debugged
trace-gui.src: W: no-version-in-last-changelog
trace-gui.src:51: W: macro-in-comment %{_bindir}
trace-gui.src:55: W: macro-in-comment %{_datadir}
trace-gui.src:55: W: macro-in-comment %{upstream_name}
trace-gui.src:56: W: macro-in-comment %{_mandir}
trace-gui.src:57: W: macro-in-comment %{_mandir}
trace-gui.src: W: invalid-url Source0: %{URL}/trace-cmd-1.0.4.tar.gz
trace-gui.x86_64: W: spelling-error Summary(en_US) cmd -> cm, cd, cad
trace-gui.x86_64: W: summary-not-capitalized C trace-cmd is a user interface to
Ftrace
trace-gui.x86_64: W: spelling-error %description -l en_US cmd -> cm, cd, cad
trace-gui.x86_64: W: spelling-error %description -l en_US debugfs -> debugs,
debuggers, debugged
trace-gui.x86_64: W: no-version-in-last-changelog
trace-gui.x86_64: W: no-manual-page-for-binary trace-graph
trace-gui.x86_64: W: no-manual-page-for-binary kernelshark
trace-gui.x86_64: W: no-manual-page-for-binary trace-view
trace-gui-debuginfo.x86_64: W: no-version-in-last-changelog

You can ignore spelling-error and no-manual-page-for-binary and
summary-not-capitalized, but the rest needs fixing.

OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
FIX - MUST: package does not meet the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines (GPLv2)
OK - MUST: License field in spec file matches the actual license
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible (could be more legible if properly formatted with
indention)
OK - MUST: sources match the upstream source by MD5
a91e23aa860359d5c4b8359ba45cef5b
OK - MUST: successfully compiles and builds into binary rpms on x86_64
N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
N/A - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK - MUST: Package does not bundle copies of system libraries.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
OK - MUST: owns all directories that it creates (none)
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: library files that end in .so are in the -devel package.
N/A - MUST: devel packages must require the base package using a fully
versioned dependency
OK - MUST: The package does not contain any .la libtool archives.
FIX - MUST: The package contains a GUI application but does not include a
%{name}.desktop file, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

OK - MUST: package does not own files or directories already owned by other
packages.
OK - Should: at the beginning of %install, the package runs rm -rf
%{buildroot}.
OK - MUST: all filenames valid UTF-8

SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
N/A - SHOULD: Scriptlets are sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
OK - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
N/A - SHOULD: package should contain man pages for binaries/scripts.

Other items:
FIX - not latest stable version (or do we rely on 1.0.4 from RHEL?)
FIX - SourceURL valid
FIX - Compiler not flags ok
OK - Debuginfo complete
OK - SHOULD: package has a %clean section, which contains rm -rf %{buildroot}.
N/A - SHOULD: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.

Issues:
- Please fix all item marked as FIX
- Please get rid of the URL macro and use a single line to make spectool work
- "Source" should be "Source0"
- Remove the stuff that is commented out, e.g. in %files to get rid of rpmlint
warnings
- make is not verbose, add V=1
- Package doesn't use %{optflags}
- Remove COPYING.LIB, not needed
- Should "Requires: trace-cmd" be versioned?
- Do not hardcode things like "prefix=/usr", "%{buildroot}/usr/bin/trace-cmd"
or "%{buildroot}/usr/share", use macros instead.
- changelog entries should contain the version as in
  https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.