[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674007

--- Comment #3 from Rich Mattes <richmattes at gmail.com> 2011-02-14 21:34:25 EST ---
I'm getting the following output from rpmlint:

$ rpmlint openni-primesense.spec ../RPMS/x86_64/openni-primesense-*
openni-primesense.spec: W: invalid-url Source0:
openni-primesense-5.0.0.25-git894cea01.tar.gz

OK

openni-primesense.x86_64: W: incoherent-version-in-changelog
5.0.0.24-0.1gitc0e70ea1 ['5.0.0.25-0.1_git894cea01.fc14',
'5.0.0.25-0.1_git894cea01']

The Release: field should read 0.1.git%{gitrev}%{?dist} and changelog entry
should read 5.0.0.24-0.1.gitc0e70ea1 as per the examples given in
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
(the SVN snapshots examples are most relevant here)

openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDeviceSensorV2.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnCore.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnFormats.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDeviceFile.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDDK.so

If these are plugin libraries akin to the openni package, this should be ok.

openni-primesense.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/openni-primesense-5.0.0.25/LGPL.txt
openni-primesense.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/openni-primesense-5.0.0.25/README

dos2unix or sed can fix these.  

openni-primesense.x86_64: E: setuid-binary /usr/bin/XnSensorServer root 04755L
openni-primesense.x86_64: E: non-standard-executable-perm
/usr/bin/XnSensorServer 04755L

Why does the sensor server binary need a setuid bit?  Device permissions should
be handled by the udev rule, is there some other reason it needs to be there?

openni-primesense.x86_64: W: log-files-without-logrotate /var/log/primesense

If there are going to be logs accumulating, you should have a rule to rotate
and delete them every so often.  It looks like XnSensorServer is creating a
folder called XnSensorServer under /var/log/primesense, but I can't get it to
add any logfiles.


openni-primesense.x86_64: W: no-manual-page-for-binary XnSensorServer

This is OK

2 packages and 1 specfiles checked; 2 errors, 11 warnings.


A few other things:

* The udev rules file mixes ATTRS and SYSFS.  SYSFS generates a lot of warning
messages at bootup, you should switch to using ATTRS consistently.

* The package has a udev rule, so it needs a Requires: on udev

* LibJPEG is bundled with openni-primesense, in Source/External.  This should
be removed in setup.

* The README file doesn't contain any useful end-user information, it's just
instructions for building and installing.  You don't need to include it as
documentation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.