[Bug 674152] Review Request: mingw32-matahari - Matahari QMF Agents for Windows guests

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674152

Andrew Beekhof <andrew at beekhof.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?                   |

--- Comment #4 from Andrew Beekhof <andrew at beekhof.net> 2011-02-16 08:21:42 EST ---
(In reply to comment #3)
> MUST: rpmlint must be run on the source rpm and all binary rpms the build
> produces. The output should be posted in the review.[1]
> 
> Needs this output

I think you're supposed to provide that but here it is anyway:

mingw32-matahari.noarch: W: spelling-error %description -l en_US ovirt ->
overt, oviduct, oviform
mingw32-matahari.noarch: W: spelling-error %description -l en_US qpid -> quid,
sapid, rapid
mingw32-matahari.src: W: spelling-error %description -l en_US ovirt -> overt,
oviduct, oviform
mingw32-matahari.src: W: spelling-error %description -l en_US qpid -> quid,
sapid, rapid
mingw32-matahari.src: W: invalid-url Source0: matahari-matahari-060266b.tgz
mingw32-matahari.spec: W: invalid-url Source0: matahari-matahari-060266b.tgz
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

The spelling errors are wrong and the spec explains how to obtain the tarball. 


[snip]

> MUST: The package must be licensed with a Fedora approved license and meet the
> Licensing Guidelines .
> MUST: The License field in the package spec file must match the actual license.
> [3]
> 
> Needs GPLv2+

Fixed.

SRPM:
http://www.clusterlabs.org/~beekhof/mingw32-matahari-0.4.0-0.12.060266b.git.fc14.src.rpm
SPEC:  http://www.clusterlabs.org/~beekhof/mingw32-matahari.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.