[Bug 677693] Review Request: tintin - TinTin++, aka tt++, is a free MUD client.

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 16 14:54:14 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=677693

--- Comment #9 from William Lima <wlima at primate.com.br> 2011-02-16 09:54:13 EST ---
(In reply to comment #8)
> (In reply to comment #7)

[...]

> 
> Would you find this okay?
> 
> --- tintin.spec 2011-02-15 19:06:36.085563092 +0100
> +++ tintin.spec.new     2011-02-16 15:27:17.439563027 +0100
> @@ -1,6 +1,6 @@
>  Name:       tintin 
>  Version:    2.00.5
> -Release:    3%{?dist}
> +Release:    4%{?dist}

[...]

> 
>  %files
>  %defattr(-,root,root,-)
> -%doc COPYING CREDITS FAQ INSTALL README *.mods
> +%doc %attr(0644,root,root) COPYING
> +%doc %attr(0644,root,root) CREDITS FAQ INSTALL README
> +%doc %attr(0755,root,root) mods/
> +%doc %attr(0644,root,root) mods/*
>  %{_bindir}/tt++
> 
>  %files doc
>  %defattr(-,root,root,-)
> -%doc COPYING
> -%doc chat_protocol.txt
> -%doc tintin19.txt
> -%doc SCRIPTS
> +%doc %attr(0644,root,root) COPYING
> +%doc %attr(0644,root,root) SCRIPTS
> +%doc %attr(0755,root,root) docs <--- remove

Do not include docs subdir, just files.

> +%doc %attr(0644,root,root) docs/*

You could use:

%doc %attr(0644,root,root) COPYING SCRIPTS docs/*

> 
>  %changelog
> +* Wed Feb 16 2011 Petr Sabata <psabata at redhat.com> - 2.00.5-4
> +- Changed documentation files structure, removed chmod's in favor of attr's
> +
>  * Tue Feb 15 2011 Petr Sabata <psabata at redhat.com> - 2.00.5-3
>  - igr.mods now gets converted to proper utf8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list