[Bug 668204] Review Request: buzzbird - Twitter and identi.ca desktop client
bugzilla at redhat.com
bugzilla at redhat.com
Wed Feb 16 20:43:17 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=668204
--- Comment #2 from Christopher Aillon <caillon at redhat.com> 2011-02-16 15:43:17 EST ---
* Your source tarball includes a few binary files including a windows EXE file
that need to get stripped. Also, if you're creating the source tarball
yourself, please consider using bzip2 or xz, which will offer better
compression (smaller tarballs).
* I looked at application.ini which claims
[Gecko]
MinVersion=1.8
MaxVersion=1.9.2.*
So please have your spec
Requires: gecko-libs >= 1.8
Requires: gecko-libs < 1.9.3
* If you're creating a .desktop file from scratch, just save it in its own
file, and include it as a Source2, like you're doing with the man page. And
send both to upstream so they can include them in the future.
* Is the extensions a Firefox extension? Based on extensions/install.rdf it
appears to be since it uses Firefox's Application ID. If so, it needs to be
installed into
%{_libdir}/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/ and
perhaps subpackaged? But unless I'm missing something, it's just a noop now,
and can probably get dropped?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list