[Bug 642208] Review Request: mingw32-win-iconv - iconv implementation using Win32 API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642208

--- Comment #2 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2011-02-17 07:39:02 EST ---
Thanks for the initial review. You're doing the review very well for a
first-timer!

Spec URL: http://ftd4linux.nl/contrib/mingw32-win-iconv.spec
SRPM URL: http://ftd4linux.nl/contrib/mingw32-win-iconv-0.0.2-1.fc15.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2846284

* Thu Feb 17 2011 Erik van Pienbroek <epienbro at fedoraproject.org> - 0.0.2-1
- Update to version 0.0.2
- Dropped upstreamed patch
- Dropped the win_iconv.exe binary
- Bumped the mingw32-iconv obsoletes

The debuginfo stuff is wrapped inside the %{?_mingw32_debug_package} macro.
There's no way to inject custom tags in this macro, so adding an obsoletes:
mingw32-iconv-debuginfo there isn't possible at the moment. AFAIK, native
Fedora packages also don't have an obsoletes on old debuginfo packages when a
new package is introduced which obsoletes an old package

Once this package gets added to Fedora all packages which depend on libiconv
have to be rebuild. I tested this in my mingw-w64 testing repository (which
contains all current fedora mingw32 packages) and it causes no (compilation)
breakage. I've also done a runtime test using my GTK-based project and it
doesn't cause any side effects. This library is also used by the GLib/Gtk
developers for their Win32/Win64 binaries of the Gtk stack:
http://ftp.gnome.org/pub/gnome/binaries/win64/dependencies/

The packages which need to be rebuilt are (according to repoquery on a F15
host):
mingw32-fontconfig-0:2.6.0-11.fc15.noarch
mingw32-gettext-0:0.17-14.fc15.noarch
mingw32-hunspell-0:1.2.12-2.fc15.noarch
mingw32-libidn-0:1.14-7.fc15.noarch
mingw32-libxml2-0:2.7.6-2.fc15.noarch
A simple rebuild is sufficient for these packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.