[Bug 678554] Review Request: iceplayer - a simple media player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678554

Mario Blättermann <mariobl at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at gnome.org

--- Comment #3 from Mario Blättermann <mariobl at gnome.org> 2011-02-18 09:08:42 EST ---
$ rpmlint iceplayer*
iceplayer.src: W: summary-not-capitalized C iceplayer - A powerful media player
for Linux
iceplayer.src: W: name-repeated-in-summary C iceplayer
iceplayer.src: E: no-changelogname-tag
iceplayer.src: W: invalid-license GPL
iceplayer.src: W: invalid-url Source0: iceplayer-4.0.3-20110214.tar.gz
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

The "Summary:" shouldn't repeat the package name.

The given source URL is not existent. The current download URL is:
http://iceplayer.googlecode.com/files/iceplayer%20src%20%204.03-20110118.tar.gz
Note that we have whitespaces in the filename, escaped with %20.

The license description should match any from the Fedora packaging guidelines:
http://fedoraproject.org/wiki/Licensing
In our case, it has to be "GPLv3", unless in future versions of this
application the authors will decide to go ahead with any successors of the
GPLv3, then it has to be changed to GPLv3+.

The %changelog is still missing. Without it, we are unable to track changes to
your package.

Remove the executable bit from any installed files, which don't need it. This
affects the files in %doc and the files in %{_datadir}.

Don't add empty files to %docs. README and NEWS are currently empty.

Use consistenly macros. The %files section should be:

%defattr (-,root,root)
%doc COPYING AUTHORS
%{_bindir}/*
%{_datadir}/%{name}/
%{_datadir}/applications/%{name}.desktop

Some "BuildRequires:" are missing. The package depends on GTK2 and GStreamer.
That's why you have to define the following:

BuildRequires: gtk2-devel gstreamer-devel

The latter points to the required gstreamer-0.10 development package.


Generally, you shouldn't leave any comments in languages other than American
English in the spec file. The Chinese ones are not really useful.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.