[Bug 678554] Review Request: iceplayer - a simple media player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678554

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #5 from Martin Gieseking <martin.gieseking at uos.de> 2011-02-18 09:39:15 EST ---
First of all, is this your first Fedora package submission? I can't find your
email address in the packager group. If so, please add FE-NEEDSPONSOR to the
Blocks field above and have a look at the following pages for further
information:

http://fedoraproject.org/wiki/PackageMaintainers/Join
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Please also enter your real name in the Bugzilla preferences.

Some additional comments on your package:

- drop the initial %define

- the Release field should be something like %{X}%{?dist} where %{X} is the 
  number to increase every time you provide a new revision of your SRPM.
  You may also add the date to the release field: %{X}.20110214%{?dist}
  To simplify packaging, add 
  %global rev 20110214
  at the beginning of the spec file and use the macro %{rev} everywhere the
  date is required.

- libnotify-devel is also required to build the package

- add %{_smp_mflags} to "make" in order to enable parallel builds

- replace %defattr (-,root,root) with %defattr (-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.