[Bug 678230] Review Request: kmldonkey - Cross-platform graphical user interface for Mldonkey

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678230

Pavel Zhukov <pavel at zhukoff.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

--- Comment #4 from Pavel Zhukov <pavel at zhukoff.net> 2011-02-18 11:39:25 EST ---
  # MUST: rpmlint must be run on the source rpm and all binary rpms the build  
produces. The output should be posted in the review.[1]
* OK
  # MUST: The package must be named according to the Package Naming Guidelines
.
* OK
  # MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
* OK
# MUST: The package must meet the Packaging Guidelines .
* OK
# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
* OK (GPLv2+)
# MUST: The License field in the package spec file must match the actual
license. [3]
* OK 
# MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
* OK
# MUST: The spec file must be written in American English. [5]
* OK
# MUST: The spec file for the package MUST be legible. [6]
* OK:
# MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. 
* OK
# MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
* OK
# MUST: If the package does not successfully compile
* OK
# MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines
* OK
# MUST: The spec file MUST handle locales properly. 
* OK
# MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
* OK
# MUST: Packages must NOT bundle copies of system libraries.
* OK
# MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. 
* OK
# MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
* OK
# MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
* OK
# MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. [15]
* OK
# MUST: Each package must consistently use macros. [16]
* OK
# MUST: The package must contain code, or permissable content. [17]
* OK
# MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
* OK
# MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]
* OK
# MUST: Header files must be in a -devel package. [19]
* OK
# MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. [19]
* OK
# MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} = 
%{version}-%{release} [21]
* OK
# MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.[20]
* OK 
# MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[22]
* OK
# MUST: Packages must not own files or directories already owned by other
packages. 
* OK
# MUST: All filenames in rpm packages must be valid UTF-8. [24]
* OK

Please contact upstream for include man page for %{_bindir//kmldonkey}

ACCEPT
This package is approved.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.