[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674007

--- Comment #4 from Tim Niemueller <tim at niemueller.de> 2011-02-19 06:14:19 EST ---
(In reply to comment #3)
> openni-primesense.x86_64: E: setuid-binary /usr/bin/XnSensorServer root 04755L
> openni-primesense.x86_64: E: non-standard-executable-perm
> /usr/bin/XnSensorServer 04755L
> 
> Why does the sensor server binary need a setuid bit?  Device permissions should
> be handled by the udev rule, is there some other reason it needs to be there?

That is, indeed, not required anymore. Fixed, it had to be that way before I
used the udev rules and I had changed that locally already.

> openni-primesense.x86_64: W: log-files-without-logrotate /var/log/primesense
> 
> If there are going to be logs accumulating, you should have a rule to rotate
> and delete them every so often.  It looks like XnSensorServer is creating a
> folder called XnSensorServer under /var/log/primesense, but I can't get it to
> add any logfiles.

I think they are overwritten, and to use them you need to configure them from
your application within OpenNI. The XnSensorServer is started automatically
once you request the corresponding device node.

> A few other things:
> 
> * The udev rules file mixes ATTRS and SYSFS.  SYSFS generates a lot of warning
> messages at bootup, you should switch to using ATTRS consistently.

Fixed. It's the way it came from ROS.

> * The package has a udev rule, so it needs a Requires: on udev

Done.

> * LibJPEG is bundled with openni-primesense, in Source/External.  This should
> be removed in setup.

Done. Uncovered an explicit "include <External/LibJPEG/jpeglib.h>". Really, how
do companies survive that have programmers doing stuff like this, and producing
code with a virtually infinite number of warnings. Well, it works
nevertheless...

> * The README file doesn't contain any useful end-user information, it's just
> instructions for building and installing.  You don't need to include it as
> documentation.

Removed.

Spec file changed in place, new SRPM is at
http://fedorapeople.org/~timn/robotics/openni-primesense-5.0.0.25-0.2.git894cea01.fc14.src.rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.