[Bug 675122] Review Request: php-pear-Auth-Yubico - Authentication class for verifying Yubico OTP tokens

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675122

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com

--- Comment #1 from Remi Collet <fedora at famillecollet.com> 2011-02-19 09:37:19 EST ---
Quick notes.

You must use
BuildRequires:    php-pear >= 1:1.4.9-1.2

Because this is the first "working" version which provides the needed macros
used in the spec. (see PHP Guidelines) A upper version is acceptable (when
required by upstream), not a lower.

The stuff in %build should go in %prep (%build will be empty)

%file should be more explicit (wildcard can introduce issues)

%{pear_xmldir}/%{name}.xml
%{pear_phpdir}/Auth

Everything else seems ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.