[Bug 676146] Review request: trace-gui - GUI tools from trace-cmd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676146

Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Christoph Wickert <cwickert at fedoraproject.org> 2011-02-19 20:22:32 EST ---
OK, makes sense. The new package looks good:

OK - $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/trace-gui-*
trace-gui.src: W: spelling-error Summary(en_US) cmd -> cm, cd, cad
trace-gui.src: W: summary-not-capitalized C trace-cmd is a user interface to
Ftrace
trace-gui.src: W: spelling-error %description -l en_US cmd -> cm, cd, cad
trace-gui.src: W: spelling-error %description -l en_US debugfs -> debugs,
debuggers, debugged
trace-gui.x86_64: W: spelling-error Summary(en_US) cmd -> cm, cd, cad
trace-gui.x86_64: W: summary-not-capitalized C trace-cmd is a user interface to
Ftrace
trace-gui.x86_64: W: spelling-error %description -l en_US cmd -> cm, cd, cad
trace-gui.x86_64: W: spelling-error %description -l en_US debugfs -> debugs,
debuggers, debugged
trace-gui.x86_64: W: no-manual-page-for-binary trace-graph
trace-gui.x86_64: W: no-manual-page-for-binary kernelshark
trace-gui.x86_64: W: no-manual-page-for-binary trace-view
3 packages and 0 specfiles checked; 0 errors, 11 warnings.

OK - MUST: package meets the Packaging Guidelines
OK - MUST: The package contains a GUI application and includes a
%{name}.desktop file, and that file is properly validated with
desktop-file-validate in the %install section
OK - not latest stable version, but should be in sync with 1.0.4 from RHEL
OK - SourceURL valid
OK - Compiler not flags ok


Two minor things:
- When using "install", add -p to preserve timestamps, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
- Please add an icon to the desktop file. As the package doesn't have an icon
of it's own, I suggest something generic like "application-x-executable",
"applications-development" or "applications-engineering". These are provided by
all icon themes.


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.