[Bug 677089] Review Request: php-pear-XML-RPC2 - XML-RPC client/server library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=677089

Haïkel Guémar <karlthered at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Haïkel Guémar <karlthered at gmail.com> 2011-02-20 11:29:22 EST ---
php-pear-XML-RPC2 (PHP noarch package)

all relevant MUST and SHOULD points are listed here.

Must: rplint on src.rpm and binary rpms   OK 
$ rpmlint -iv php-pear-XML-RPC2-1.0.6-1.fc14.src.rpm
php-pear-XML-RPC2.src: I: checking
php-pear-XML-RPC2.src: I: checking-url http://pear.php.net/package/XML_RPC2
(timeout 10 seconds)
php-pear-XML-RPC2.src: I: checking-url
http://pear.php.net/get/XML_RPC2-1.0.6.tgz (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -iv php-pear-XML-RPC2-1.0.6-1.fc14.noarch.rpm
php-pear-XML-RPC2.noarch: I: checking
php-pear-XML-RPC2.noarch: I: checking-url http://pear.php.net/package/XML_RPC2
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


MUST: package is named accordingly to general and PHP specific naming
guidelines. OK

MUST: spec file name matches %{name} OK

MUST: package meet general and PHP/PEAR packaging guidelines. OK 

MUST: package is licensed under a fedora compliant license (LGPLv2+) OK

MUST: spec is written in legible american english. OK

MUST: provided and upstream sources checksums match.  OK
provided sources: a7ac54a9d89257dd4f2a4f20c88d9f8ee5b77a03
upstream sources: a7ac54a9d89257dd4f2a4f20c88d9f8ee5b77a03

MUST: compilation tested on all supported platforms (x86 and x86_64) for F14
under mock. OK
Note: not difficult since this is a noarch package ;)

MUST: package doesn't bundle third party libraries. OK

MUST: package owns created directories (and only them). OK

MUST: files are not listed twice. OK

MUST: files permissions are properly set. OK

MUST: consistent use of macros. OK

MUST: only ships permissible content. OK

MUST: doc is properly handled. OK

MUST: filenames are valid UTF-8. OK 

SHOULD: package functions as described. OK
Note: i was able to build a minimal XML-RPC client (thanks to XML_RPC2
documentation) and it worked as expected.

General and php/PEAR specific guidelines are respected, as for the files
excluded, an upstream ticket has been opened and it doesn't seem to prevent it
from working.
Hereby, i grant this package my approval to join Fedora packages collection.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.