[Bug 678929] Review Request: perl-Crypt-Random-Source - Get weak or strong random data from pluggable sources

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678929

Sergio Belkin <sebelk at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebelk at gmail.com

--- Comment #1 from Sergio Belkin <sebelk at gmail.com> 2011-02-21 09:27:34 EST ---
Some comments: 

(Note that I am (still) not member of packaging group)

I see no errors buiding this package, and is compliant with Packaging Perl
Guideline

-License:

Terms of the Perl programming language system itself

a) the GNU General Public License as published by the Free
   Software Foundation; either version 1, or (at your option) any
   later version, or
b) the "Artistic License"

- Dir ownership for noarch packages ok
- Dependencies ok as
http://deps.cpantesters.org/?module=Crypt::Random::Source;perl=latest and
http://fedoraproject.org/wiki/Packaging:Perl#Perl_Requires_and_Provides states.

c) Filtering Requires and Provides 
%{?perl_default_filter}

ok!

d) URL tag ok

e) test suite present:

%check
make test

In short I see no errors and rpmlint only it outputs a harmless warning:

rpmlint -i -v perl-Crypt-Random-Source*
perl-Crypt-Random-Source.noarch: I: checking
perl-Crypt-Random-Source.noarch: W: spelling-error Summary(en_US) pluggable ->
plug gable, plug-gable, plugged
The value of this tag appears to be misspelled. Please double-check.

perl-Crypt-Random-Source.noarch: I: checking-url
http://search.cpan.org/dist/Crypt-Random-Source/ (timeout 10 seconds)
perl-Crypt-Random-Source.src: I: checking
perl-Crypt-Random-Source.src: W: spelling-error Summary(en_US) pluggable ->
plug gable, plug-gable, plugged
The value of this tag appears to be misspelled. Please double-check.

perl-Crypt-Random-Source.src: I: checking-url
http://search.cpan.org/dist/Crypt-Random-Source/ (timeout 10 seconds)
perl-Crypt-Random-Source.src: I: checking-url
http://www.cpan.org/authors/id/N/NU/NUFFIN/Crypt-Random-Source-0.07.tar.gz
(timeout 10 seconds)
perl-Crypt-Random-Source.spec: I: checking-url
http://www.cpan.org/authors/id/N/NU/NUFFIN/Crypt-Random-Source-0.07.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.


Hope that helps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.