[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678728

Sergio Belkin <sebelk at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebelk at gmail.com

--- Comment #2 from Sergio Belkin <sebelk at gmail.com> 2011-02-21 11:55:44 EST ---
Hi Andreas!

Your rpm has some issues: (I am (still) not member of Packaging group, however
I hope you find this little review useful):

synce-connector.i686: W: non-conffile-in-etc /etc/ppp/peers/synce-bt-peer
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

http://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files and
http://fedoraproject.org/wiki/Common_Rpmlint_issues#non-conffile-in-etc


You could take a look to wvdial spec for example

http://pkgs.fedoraproject.org/gitweb/?p=wvdial.git;a=blob;f=wvdial.spec;h=3bfc6ac99840938218ebf0fc53fb0dabd4d997a6;hb=master

HTH

Greets

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.