[Bug 650283] Review Request: rubygem-rspec-core - Rspec-2 runner and formatters

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=650283

--- Comment #3 from Vít Ondruch <vondruch at redhat.com> 2011-02-21 12:15:22 EST ---
At first, could you please explain how are you going to build all these
packages? I assume that in first iteration, you are going to change
need_bootstrap to 0 and in the second iteration, you are going to remove this
constant and conditions completely, is that right?

* Bindir
  - Please consider usage of '--bindir .%{_bindir} \' in the gem install
command.
    This would allow you to remove all the cruft beginning by line 86.

* Autospec
  - Since autospec command is deprecated and moreover completely useless, I
would
    suggest its remove.
  - Moreover, autospec-2 is not aligned with MiniTest naming, where testrb2 is
    used to avoid conflicts.

* Test suite
  - The test suite is really tricky :/ I have tried to run all the specs and
there
    are failing not only for autospec part, also for formatters. I have created
    several upstream bugs to cover this:
    https://github.com/rspec/rspec-core/issues/318
    https://github.com/rspec/rspec-core/issues/319
  - Cucumber specs has several failures as well
    https://github.com/rspec/rspec-core/issues/320
  - It is not hopefully showstopper
  - The selected subset works just fine

* Documentation
  - Files in -doc subpackage are not marked as documentation. That is reported
    by rpmlint. They can by appropriately queried later:

    $ rpm -qp -d noarch/rubygem-rspec-core-doc-2.5.1-1.fc14.noarch.rpm

  - It is messaged by rpmlint

* rpmlint output
  - rubygem-rspec-core-doc.noarch: W: hidden-file-or-dir 
        /usr/lib/ruby/gems/1.8/gems/rspec-core-2.5.1/features/.nav
  - rubygem-rspec-core.src: W: spelling-error 
        %description -l en_US Behaviour -> Behavior, Behave, Behalves

* Koji scratch build
  - http://koji.fedoraproject.org/koji/taskinfo?taskID=2854668
  - with need_bootstrap set to 1, the build is successful.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.