[Bug 678727] Review Request: pam-afs-session - AFS PAG and AFS tokens on login (sponsor requested)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678727

Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steve.traylen at cern.ch

--- Comment #1 from Steve Traylen <steve.traylen at cern.ch> 2011-02-22 14:43:57 EST ---
Hi Ken,

Some initial comments:

1)
Name: pam-afs-session

There are some guidelines on the naming of pam modules:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28httpd.2C_pam.2C_and_SDL.29

though in this case I appreciate it supersedes the normal "use
name of tar ball" which you followed.

2)
A very recent addition to the "rules" is to add %{?_isa} to the 
end of your -devel Buildrequires. e.g.

BuildRequires: pam-devel%{?_isa}

Other than that at first site it's looking pretty good.

Generally have a look at the "Getting Sponsored" pages. Provide some
informal reviews of other pending packages from here:

http://fedoraproject.org/PackageReviewStatus/NEW.html

I'd avoid the "Need sponsor" ones. 

Report back here with some links to some reviews you have made.

Steve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.