[Bug 678980] Review Request: openscad - Creates solid 3D CAD objects

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678980

--- Comment #7 from jebba <moe at blagblagblag.org> 2011-02-22 14:57:05 EST ---
(In reply to comment #6)
> Here are some additional comments:

Wow, thanks for all your suggestions. I have implemented them, but have a
question about the Version/Release.

> - 2011.02.20git is not a valid version number. Replace it with 2011.02.20 as
>   this seems to be the version number chosen by upstream. 
> 
> - change the Release field according to 
>   http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages
>   e.g. Release: 0.%{X}.20110222git%{REV}%{?dist}
>   where %{X} is the revision number to increase, and %{REV} is the Git 
>   changeset hash used to build the package

Doing the above, if I understood correctly, results in quite a long package
name, with the date in there twice:

openscad-2011.02.22-0.1.20110222git420c36603b.fc14.src.rpm

Is this OK/correct? Maybe this (still long) would be better:

openscad-2011.02.22-0.1.git420c36603b.fc14.src.rpm

Thanks again!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.