[Bug 678221] Review Request: perl-EV - Wrapper for the libev high-performance event loop library

Wed Feb 23 23:08:10 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=678221

--- Comment #4 from Emmanuel Seyman <emmanuel.seyman at club-internet.fr> 2011-02-23 18:08:10 EST ---
(In reply to comment #3)
>
> Since this is only going to Fedora >= 15 anyway (dependency on libev), I
> removed the Buildroot line.

Note that, while you're at it, the %clean section is not required for F-13 and
above.

> The sources of libev are BSD or GPLv2+, hence the License tag.
> 
> However, I must admit that I'm not sure I did it right license-wise:
> - since I'm building against the system-provided sources of libev, should I
> just remove the part related to the libev sources?
> - since the sources are still included in the source rpm, should I leave it as
> is?

I'm going to go with the first solution.

Fix this and I'll approve your package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.