[Bug 678925] Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG algorithm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678925

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |iarnell at gmail.com
         AssignedTo|nobody at fedoraproject.org    |iarnell at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2011-02-23 23:27:36 EST ---
+ source files match upstream.  
    46110b9a7bb96fe641bdfaf35bdafec5  Math-Random-ISAAC-1.004.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ license field matches the actual license.
    MIT or GPL+ or Artistic

+ license is open source-compatible.
+ license text included.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2862720

+ package installs properly.
- rpmlint has complaints:
    perl-Math-Random-ISAAC.noarch: W: invalid-license Artistic
    perl-Math-Random-ISAAC.noarch: E: wrong-script-end-of-line-encoding
/usr/share/doc/perl-Math-Random-ISAAC-1.004/examples/benchmark.pl
    perl-Math-Random-ISAAC.noarch: E: wrong-script-end-of-line-encoding
/usr/share/doc/perl-Math-Random-ISAAC-1.004/examples/distribution.pl
    perl-Math-Random-ISAAC.src: W: invalid-license Artistic
    2 packages and 0 specfiles checked; 2 errors, 2 warnings.

+ final provides and requires are sane:
    perl(Math::Random::ISAAC) = 1.004
    perl(Math::Random::ISAAC::PP) = 1.004
    perl-Math-Random-ISAAC = 1.004-1.fc16
=
    perl(Carp)  
    perl(integer)  
    perl(:MODULE_COMPAT_5.12.3)  
    perl(strict)  
    perl(warnings)  

+ %check is present and all tests pass.
    PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
    t/01compile.t .............. ok
    t/02sequence.t ............. ok
    t/03memory.t ............... ok
    t/04uniform.t .............. skipped: Author tests not required for
installation
    t/05fallback.t ............. skipped: Test::Without::Module and
Math::Random::ISAAC::XS required to test fallback ability
    t/06exceptions.t ........... ok
    t/release-dist-manifest.t .. skipped: these tests are for release candidate
testing
    t/release-kwalitee.t ....... skipped: these tests are for release candidate
testing
    t/release-pod-coverage.t ... skipped: these tests are for release candidate
testing
    t/release-pod-syntax.t ..... skipped: these tests are for release candidate
testing
    t/release-portability.t .... skipped: these tests are for release candidate
testing
    All tests successful.
    Files=11, Tests=609,  1 wallclock secs ( 0.08 usr  0.02 sys +  0.27 cusr 
0.03 csys =  0.40 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


Looks like rpmlint gets confused with "MIT or GPL+ or Artistic", but can be
ignored - the license is good.

The wrong-script-end-of-line-encoding should be fixed in %prep: sed -i 's/\r//'
examples/*.pl

APPROVED with that one minor tweak.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.