[Bug 676879] Review Request: mpiexec - MPI job launcher that uses the PBS task interface directly

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676879

--- Comment #6 from Christos Triantafyllidis <christos.triantafyllidis at gmail.com> 2011-02-24 03:28:59 EST ---
Hey Steve,
   thanks for getting this! Find my answers/comments inline.

(In reply to comment #5)
> How does this relate to 
> 
> mpich2 which contains:
> /usr/lib/mpich2/bin/mpiexec
> and
> openmpi
> which contains
> /usr/lib/openmpi/bin/mpiexec
> 
> 
> http://fedoraproject.org/wiki/PackagingDrafts/MPI
> 
> may have some clues.
> 
I would say that this is yet another mpiexec :).

The benefit of using this package is that it integrates with the PBS which
means that it takes advantage of features like correct accounting for MPI jobs.
Another issue that this solves is that it is compatible with many MPI
implementations (including openmpi and mpich2). Check this as the vendor
explains why there are so many mpiexecs:
http://www.osc.edu/~djohnson/mpiexec/index.php#Too_many_mpiexecs


> As for your last question about signifying which torque version you build
> against
> then this is implicit since the package in a particular EPEL or Fedora release
> and
> so is built against which ever torque is in that platform. You don't need the
> "toruqe_XXX" 
> in the release.
> 
> Also the resulting requires
> $ rpm -qp --requires mpiexec-0.84-1_torque_2.3.13.fc14.x86_64.rpm  | grep
> torque
> libtorque.so.2()(64bit)
> 
> should be enough to tie version.

Actually my concern here is that this mpiexec supports other PBS
implementations (i.e. OpenPBS or PBSPro). Currently they are not in fedora/epel
but what if they appear later? Is it safe/OK to remove this from the release
for now and think about it if/when they may appear?

> 
> The pbs location changes between EPEL5 and 6 and in Fedora so I recommend some
> conditionals:
> http://fedoraproject.org/wiki/DistTag#Conditionals
> However this review is by default for rawhide so it must be correct for that.

This sounds trivial. Is it sufficient to distinguish between EPEL5, EPEL6 and
Fedora or should i also distinguish torque release? Even better is there anyway
that i can get this path from currently installed torque version?

> 
> I see there is both a GPL LICENSE file but also a "LICENSE.mvapich" file which
> is
> probably BSD. Is this dual licensed or something ? Can you clarify.

According to the last line of vendor's description page:
http://www.osc.edu/~djohnson/mpiexec/index.php#Description

"Mpiexec is free software and is licensed for use under the GNU General Public
License, version 2." 

Is this sufficient or should i clarify this with vendor?

> 
> Steve.

Many thanks once more for reviewing this.

Christos

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.