[Bug 673589] Review Request: UpTools - C++ library for hpc, networking, db, memory, etc.

bugzilla at redhat.com bugzilla at redhat.com
Fri Feb 25 15:07:04 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673589

--- Comment #28 from Ralf Corsepius <rc040203 at freenet.de> 2011-02-25 10:07:03 EST ---
2 details:

* I'd recommend to append --disable-silent-rules to %configure
This makes build logs much better readable (You could drop the make V=1, then)

* The *-devel package applies libstdc++
=> Please add
Requires: libstdc++-devel


Another detail I do not understand:
...
checking for mysql_close in -lmysqlclient... no
checking for mysqlclient library with -L/lib64... no
checking for mysqlclient library with -L/lib... no
checking for mysqlclient library with -L/usr/lib64... no
checking for mysqlclient library with -L/usr/lib... no
checking for mysqlclient library with -L/usr/local/lib64... no
checking for mysqlclient library with -L/usr/local/lib... no
checking for mysqlclient library with -L/usr/local/lib64/mysql... no
checking for mysqlclient library with -L/usr/lib64/mysql... yes
checking mysql/mysql.h usability... yes
checking mysql/mysql.h presence... yes
checking for mysql/mysql.h... yes


2 issues with this:

1. ".lmysqlclient... no"
At least Fedora 14 has "mysql_close in -lmysqlclient"
# nm -sD /usr/lib64/mysql/libmysqlclient.so | grep mysql_close
00000039e5450580 T mysql_close


2. The lib../usr/lib... iteration.
This a pretty questionable way to check for a library.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list