[Bug 225670] Merge Review: cups

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225670

--- Comment #6 from Tim Waugh <twaugh at redhat.com> 2011-02-25 10:57:42 EST ---
(In reply to comment #5)
> cups.src:259: W: macro-in-comment %patch28
> cups.src: W: patch-not-applied Patch28: cups-gnutls-gcrypt-threads.patch
> ^^^ please apply the patch or remove it

Gone.

> cups.x86_64: W: obsolete-not-provided LPRng
> ^^^ I think LPRng should be provided

The history behind this is in bug #148757.

> cups.x86_64: W: file-not-utf8 /usr/share/doc/cups-1.4.3/CREDITS.txt
> ^^^ Please convert this file to UTF-8 during build process. `man 1 iconv` is
>     your friend

I believe it is now UTF-8 upstream.

> cups-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libcupscgi.so.1
> exit at GLIBC_2.2.5
> ^^^ Please explain why it is acceptable (for example self-implemented stack
> protector
>     is a good reason to call exit inside library)

This shared library is only used internally by CUPS (it is used by several of
the CGI handlers).  It is simply to share code between CUPS programs.

> cups-lpd.x86_64: W: spelling-error %description -l en_US provices
> cups-php.x86_64: W: spelling-error %description -l en_US provices
> ^^^ Probably typos

Both fixed.

> The PIE problem:

I've removed --enable-pie from the configure options as this is (sort of) done
automatically upstream.

The upstream build process is not sophisticated enough to handle passing
exactly the right parameters.  It uses -fPIC (not -fPIE) when compiling, which
Jakub assures me is simply slightly less efficient that -fPIE in some cases. 
Indeed, the resulting executables behave as PIEs and seem to have the correct
ELF flags set.

The upstream discussion about it is here:
http://cups.org/str.php?L3691

Please take a look at cups-1.4.6-6.fc14.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.