[Bug 518441] Review Request: ike - Shrew Soft VPN Client For Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518441

Ruediger Landmann <r.landmann at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?,
                   |                            |needinfo?(andrew at topdog.za.
                   |                            |net)

--- Comment #29 from Ruediger Landmann <r.landmann at redhat.com> 2011-02-25 19:41:57 EST ---
Andrew -- rpmlint shows some problems:

$ rpmlint /home/rlandmann/rpmbuild/RPMS/x86_64/ike-2.1.7-3.fc14.x86_64.rpm
ike.x86_64: E: executable-marked-as-config-file /etc/logrotate.d/ike
ike.x86_64: W: spurious-executable-perm /etc/logrotate.d/ike
ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libith.so
ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/liblog.so
ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libip.so
ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libike.so
ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libpfk.so
ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libidb.so
ike.x86_64: W: service-default-enabled /etc/rc.d/init.d/iked
1 packages and 0 specfiles checked; 1 errors, 8 warnings.

Please update the spec file so that you:

* install /etc/logrotate.d/ike with mode 644
* put the .so files in a -devel subpackage

I agree with your reasoning about having the service enabled and ready to use
on installation.

When you've rebuilt the SRPM to address the above points, verify the rpmlint
output and I'll complete this review.

Cheers
Rudi

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.