[Bug 673589] Review Request: UpTools - C++ library for hpc, networking, db, memory, etc.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673589

--- Comment #30 from Sergio Belkin <sebelk at gmail.com> 2011-02-26 18:14:01 EST ---
(In reply to comment #28)
> 2 details:
> 
> * I'd recommend to append --disable-silent-rules to %configure
> This makes build logs much better readable (You could drop the make V=1, then)

Thanks Ralf for your autotools wisdom :)
Done!

> 
> * The *-devel package applies libstdc++
> => Please add
> Requires: libstdc++-devel
Done!


> 
> 
> Another detail I do not understand:
> ...
> checking for mysql_close in -lmysqlclient... no
> checking for mysqlclient library with -L/lib64... no
> checking for mysqlclient library with -L/lib... no
> checking for mysqlclient library with -L/usr/lib64... no
> checking for mysqlclient library with -L/usr/lib... no
> checking for mysqlclient library with -L/usr/local/lib64... no
> checking for mysqlclient library with -L/usr/local/lib... no
> checking for mysqlclient library with -L/usr/local/lib64/mysql... no
> checking for mysqlclient library with -L/usr/lib64/mysql... yes
> checking mysql/mysql.h usability... yes
> checking mysql/mysql.h presence... yes
> checking for mysql/mysql.h... yes
> 
> 
> 2 issues with this:
> 
> 1. ".lmysqlclient... no"
> At least Fedora 14 has "mysql_close in -lmysqlclient"
> # nm -sD /usr/lib64/mysql/libmysqlclient.so | grep mysql_close
> 00000039e5450580 T mysql_close
> 
> 
> 2. The lib../usr/lib... iteration.
> This a pretty questionable way to check for a library.

You're right, I wrongly overlooked.
I've fixed that, adding the appropiate LDFLAGS for mysql.
I agree that the "iteration" (using ax_ext_have_lib.m4) it's not the more usual
and perhaps better way to do that. In fact, it outputs a misleading message as
if mysql_close was not in mysqlclient. But please take into account 2 things:

1. The macro finds it (uses AC_TRY_LINK_FUNC to do it) when it searches through
the "right" directory, either /usr/lib/mysql or /usr/lib64/mysql depending of
the arch (of course if mysql-devel is installed). The problem is that it uses a
misleading message.
2. I know that I could use AC_SEARCH_LIBS for find but please, let's take in
account that many programmers are a bit lazy in order to pass the right
LDFLAGS, believe that there are a lot of them that even know what is "LDFLAGS".
So We want to be easy to install from sources.
Mmmm... Well, I feel that I changed the main subject that is to build fedora
packages. Of course is my will improve the packages in future releases and use
better ways that find libraries and even examine that ax_ext_have_lib.m4 macro
and submitted patches if it so happens. 

The two issues has been fixed.

Thanks for your comments! Next reply to Mamoru I post the updated files url

Thanks again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.