[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
bugzilla at redhat.com
bugzilla at redhat.com
Mon Feb 28 18:20:08 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678128
Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |mtasaka at ioa.s.u-tokyo.ac.jp
Flag| |fedora-review?
--- Comment #14 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2011-02-28 13:20:06 EST ---
Some comments
* License
- The license tag should be GPLv2+, from source codes and
man file.
* Timestamps
- Please consider to use
---------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
---------------------------------------------------------
to keep timestamps on installed man file.
? ${LIBS}
- It seems that before setting LIBS environ LIBS is null, and
LIBS="-lm" is sufficient.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list