[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678128

--- Comment #15 from Sergio Belkin <sebelk at gmail.com> 2011-02-28 14:55:26 EST ---
(In reply to comment #14)

Updated file URL's
***
Spec URL: http://dl.dropbox.com/u/14217893/cdw.spec
SRPM URL: http://dl.dropbox.com/u/14217893/cdw-0.6.0-7.fc16.src.rpm
***

> Some comments
> 
> * License
>   - The license tag should be GPLv2+, from source codes and
>     man file.

You're right. Fixed.

> 
> * Timestamps
>   - Please consider to use
> ---------------------------------------------------------
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
> ---------------------------------------------------------
>     to keep timestamps on installed man file.

Fixed!

> 
> ? ${LIBS}
>   - It seems that before setting LIBS environ LIBS is null, and
>     LIBS="-lm" is sufficient.

Yup, it's null, fixed too!

Thanks Mamoru!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.